Messages in this thread | | | Date | Wed, 23 Nov 2011 11:49:26 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH RFC] watchdog: add a new driver for VIA chipsets |
| |
(BTW I removed a few duplicates from the CC list)
> A question regarding "nowayout", in the case of this VIA chipset where > a watchdog can not be stopped once started from BIOS. I think I should > set unconditionally WDOG_NO_WAY_OUT in status, shouldn't I ? > > I also do not think it is correct to implement a timer and ping > proactively in case of magicclose because 1) it complicates a bit the > code, 2) there is no way to know the timeout value, and it set very low > in the BIOS (1 s).
Yup, I'd accept the reason that you can't know the timeout value and then setting NO_WAY_OUT unconditionally looks like the thing to do here.
@Wim: Would you accept drivers which can only ping a watchdog but neither start/stop it?
@Marc: If he does, would you be interested in updating the watchdog-core so that no start()/stop() will also be accepted if there is a ping()?
Regards,
Wolfram
-- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | [unhandled content-type:application/pgp-signature] | |