Messages in this thread Patch in this message | | | Date | Tue, 22 Nov 2011 16:20:56 -0800 | From | Greg KH <> | Subject | [06/25] PM / Suspend: Off by one in pm_suspend() |
| |
2.6.32-longterm review patch. If anyone has any objections, please let me know.
------------------ Content-Length: 833 Lines: 29
From: Dan Carpenter <dan.carpenter@oracle.com>
commit 528f7ce6e439edeac38f6b3f8561f1be129b5e91 upstream.
In enter_state() we use "state" as an offset for the pm_states[] array. The pm_states[] array only has PM_SUSPEND_MAX elements so this test is off by one.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
--- kernel/power/suspend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
--- a/kernel/power/suspend.c +++ b/kernel/power/suspend.c @@ -293,7 +293,7 @@ int enter_state(suspend_state_t state) */ int pm_suspend(suspend_state_t state) { - if (state > PM_SUSPEND_ON && state <= PM_SUSPEND_MAX) + if (state > PM_SUSPEND_ON && state < PM_SUSPEND_MAX) return enter_state(state); return -EINVAL; }
| |