Messages in this thread | | | Date | Tue, 22 Nov 2011 14:18:29 -0800 | From | Greg KH <> | Subject | Re: [PATCH 05/15] samsung-laptop: ehance SABI support |
| |
On Tue, Nov 22, 2011 at 11:02:36PM +0100, Corentin Chary wrote: > * SABI command are on 16 bits, not 8
Are you sure about that? I guess this would work, and we rely on the bits being in the right order so everything works properly?
> * SABI can read/write up to 11 byte of data
It can?
> * There is not real difference between "get" and "set" > commands, so refactorise the code of both functions
Ah, nice, I always wanted to do that.
> Signed-off-by: Corentin Chary <corentincj@iksaif.net>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
| |