lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH RFC] watchdog: add a new driver for VIA chipsets
Wolfram Sang <w.sang@pengutronix.de> wrote:

> > + dev_info(&pdev->dev, "VIA Chipset watchdog MMIO: %x\n", mmio);
> > + if (mmio == 0) {
> > + dev_err(&pdev->dev, "watchdog timer is not enabled in BIOS\n");
> > + return -ENODEV;
> > + }
>
> What about
>
> if (mmio != 0) {
> dev_info("VIA Chipset...")
> } else {
> dev_err()
> return -ENODEV;
> }
>
> to only have the needed printouts.
>
Ok.

> > + ret = watchdog_register_device(&wdt_dev);
> > + if (ret)
> > + return ret;
>
> You need to iounmap in the error-case.
Yes. Good catch.

>
> > + watchdog_set_drvdata(&wdt_dev, wdt_mem);
> > + if (readl(wdt_mem) & VIA_WDT_FIRED) {
> > + wdt_dev.bootstatus |= WDIOF_CARDRESET;
> > + dev_notice(&pdev->dev, "restarted by expired watchdog\n");
>
> Skip the printout. This can be detected using CARDRESET.
>
Ok.

> > +/*
> > + * The driver has not been tested yet on CX700 and VX800.
> > + */
>
> Then, I'd rather skip this comment and the IDs. Or if you are sure enough it
> works, leave them in ;) Best option would be testers showing up.
>
Then I take the risk and remove the comments ;). This is stable stuff inherited
from old models...

> Regards,
>
> Wolfram
>
Thanks for your comments, I'm preparing an update.
--
Marc


\
 
 \ /
  Last update: 2011-11-22 19:13    [W:0.084 / U:1.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site