Messages in this thread | | | Date | Tue, 22 Nov 2011 11:26:03 -0500 (EST) | From | Alan Stern <> | Subject | Re: [PATCH 1/1] xHCI: Adding #define values used for hub descriptor |
| |
On Tue, 22 Nov 2011, Aman Deep wrote:
> xhci-hub used some numerical values for initialisation of root hub > descriptors. #define values are addded in usb 2.0 hub specification > file and these values are used for root hub characteristics > initialisation. > > Also use some #defines in places where magic numbers are being used.
This is good. Can you also add similar changes to hub_configure() in drivers/usb/core/hub.c?
Alan Stern
| |