lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 2/2] misc: ad525x_dpot: Add support for SPI module device table matching
Date
On Friday 18 November 2011, michael.hennerich@analog.com wrote:
> From: Michael Hennerich <michael.hennerich@analog.com>
>
> Passing device name via platform data, is a leftover from times where
> SPI module device table matching was not existent.
>
> * Add id_table and remove old mechanism.
> (To my knowledge no intree boards affected)
> * Miscellaneous other cleanup.

The patch looks good to me, but please don't do "miscelaneous other cleanup"
in the same patch. I think doing cleanups while you change a driver is
a good idea, just do the extra step to split those out into a cleanup
patch and describe what you do, just like you have split out the bug fix.

Arnd


\
 
 \ /
  Last update: 2011-11-22 17:15    [W:0.190 / U:1.324 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site