lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRE: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its implementation
Date
From
Ack

This driver is maintained by Achim Leubner
<Achim_Leubner@pmc-sierra.com> and Mahesh Rajashekhara
<Mahesh_Rajashekhara@pmc-sierra.com>. I have added them so that either
one of them can have the opportunity to respond.

Sincerely -- Mark Salyzyn

-----Original Message-----
From: linux-scsi-owner@vger.kernel.org
[mailto:linux-scsi-owner@vger.kernel.org] On Behalf Of Thomas Meyer
Sent: Thursday, November 17, 2011 5:44 PM
To: JBottomley@parallels.com; linux-scsi@vger.kernel.org;
linux-kernel@vger.kernel.org
Subject: [PATCH] [SCSI] aacraid: Use kmemdup rather than duplicating its
implementation
The semantic patch that makes this change is available
in scripts/coccinelle/api/memdup.cocci.

Signed-off-by: Thomas Meyer <thomas@m3y3r.de>
---
diff -u -p a/drivers/scsi/aacraid/commctrl.c
b/drivers/scsi/aacraid/commctrl.c
--- a/drivers/scsi/aacraid/commctrl.c 2011-11-07 19:38:06.463566391
+0100
+++ b/drivers/scsi/aacraid/commctrl.c 2011-11-08 10:53:23.848146953
+0100
@@ -631,15 +631,14 @@ static int aac_send_raw_srb(struct aac_d
}
} else {
struct user_sgmap* usg;
- usg = kmalloc(actual_fibsize - sizeof(struct
aac_srb)
- + sizeof(struct sgmap), GFP_KERNEL);
+ usg = kmemdup(upsg,
+ actual_fibsize - sizeof(struct
aac_srb) + sizeof(struct sgmap),
+ GFP_KERNEL);
if (!usg) {
dprintk((KERN_DEBUG"aacraid: Allocation
error in Raw SRB command\n"));
rcode = -ENOMEM;
goto cleanup;
}
- memcpy (usg, upsg, actual_fibsize -
sizeof(struct aac_srb)
- + sizeof(struct sgmap));
actual_fibsize = actual_fibsize64;

for (i = 0; i < usg->count; i++) {

\
 
 \ /
  Last update: 2011-11-22 15:41    [from the cache]
©2003-2011 Jasper Spaans