lkml.org 
[lkml]   [2011]   [Nov]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 2/5] writeback: charge leaked page dirties to active tasks
    On Tue, Nov 22, 2011 at 05:49:29AM +0800, Andrew Morton wrote:
    > On Mon, 21 Nov 2011 21:03:44 +0800
    > Wu Fengguang <fengguang.wu@intel.com> wrote:
    >
    > > It's a years long problem that a large number of short-lived dirtiers
    > > (eg. gcc instances in a fast kernel build) may starve long-run dirtiers
    > > (eg. dd) as well as pushing the dirty pages to the global hard limit.
    > >
    > > The solution is to charge the pages dirtied by the exited gcc to the
    > > other random dirtying tasks. It sounds not perfect, however should
    > > behave good enough in practice, seeing as that throttled tasks aren't
    > > actually running so those that are running are more likely to pick it up
    > > and get throttled, therefore promoting an equal spread.
    > >
    > > --- linux-next.orig/mm/page-writeback.c 2011-11-17 20:57:04.000000000 +0800
    > > +++ linux-next/mm/page-writeback.c 2011-11-17 20:57:13.000000000 +0800
    > > @@ -1194,6 +1194,7 @@ void set_page_dirty_balance(struct page
    > > }
    > >
    > > static DEFINE_PER_CPU(int, bdp_ratelimits);
    > > +DEFINE_PER_CPU(int, dirty_leaks) = 0;
    >
    > This is a poor identifier for a global symbol. Generally such symbols
    > should at least identify what subsystem they belong to.

    Yes it is, "dirty_throttle_leaks" should look better.

    > Also, this would be a good site at whcih to document the global
    > symbol's role. The writeback code needs a lot of documentation. Of
    > the design-level kind.

    Agreed, I just added this comment:

    /*
    * Normal tasks are throttled by
    * loop {
    * dirty tsk->nr_dirtied_pause pages;
    * take a snap in balance_dirty_pages();
    * }
    * However there is a worst case. If every task exit immediately when dirtied
    * (tsk->nr_dirtied_pause - 1) pages, balance_dirty_pages() will never be
    * called to throttle the page dirties. The solution is to save the not yet
    * throttled page dirties in dirty_throttle_leaks on task exit and charge them
    * randomly into the running tasks. This works well for the above worst case,
    * as the new task will pick up and accumulate the old task's leaked dirty
    * count and eventually get throttled.
    */

    Thanks,
    Fengguang


    \
     
     \ /
      Last update: 2011-11-22 14:37    [W:0.026 / U:0.284 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site