Messages in this thread | | | From | Stephen Warren <> | Date | Mon, 21 Nov 2011 16:40:49 -0800 | Subject | RE: [PATCH] s3c/s3c24xx: arm: leds: Make s3c24xx LEDS driver use gpiolib |
| |
Denis Kuzmenko wrote at Monday, November 21, 2011 5:28 PM: > On 11/22/2011 01:39 AM, Stephen Warren wrote: ... > > Anyway, I guess that means that your patch V1 is at least a pure conversion > > of the code from custom functions to gpiolib, even if what it was and still > > is doing doesn't make much sense to me. > > > > So what do you suggest? Leave original behavior? > I'd like to remove pull-related actions at all considering: > - power consumption > - we are both not able to find any sense in that code > - s3c2410_gpio_pullup looks like deprecated > - can't imagine situation where this change will break functionality > (of course when this code used to drive actually LED and not something else)
Well, if that works for you, that makes sense to me too.
-- nvpublic
| |