[lkml]   [2011]   [Nov]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 3/4] vfs: count unlinked inodes
    On Mon, Nov 21, 2011 at 12:11:32PM +0100, Miklos Szeredi wrote:
    > Do not WARN_ON if set_nlink is called with zero count, just do a
    > ratelimited printk. This happens on xfs and probably other
    > filesystems after an unclean shutdown when the filesystem reads inodes
    > which already have zero i_nlink. Reported by Christoph Hellwig.

    Given that this is part of the normal recovery process printing anything
    seems like a bad idea. I also don't think the code for this actually
    is correct.

    Remember when a filesystem recovery from unlinked but open inodes the
    following happens:

    - we walk the list of unlinked but open inodes, and read them into
    memory, remove the linkage and then iput it.

    With the current code that won't ever increment s_remove_count, but
    decrement it from __destroy_inode. I suspect the right fix is to
    simply not warn for a set_nlink to zero, but rather simply increment
    s_remove_count for that case.

     \ /
      Last update: 2011-11-21 12:37    [W:0.019 / U:23.208 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site