Messages in this thread | | | Date | Sun, 20 Nov 2011 15:23:42 -0800 | From | "Paul E. McKenney" <> | Subject | Re: [PATCH 2/5] rcu: Fix macro substitution for synchronize_rcu_bh() on RT |
| |
On Fri, Nov 18, 2011 at 11:45:12PM -0500, Steven Rostedt wrote: > From: John Kacur <jkacur@redhat.com> > > kernel/rcutorture.c:492: error: ‘synchronize_rcu_bh’ undeclared here (not in a function) > > synchronize_rcu_bh() is not just called as a normal function, but can > also be referenced as a function pointer. When CONFIG_PREEMPT_RT_FULL > is enabled, synchronize_rcu_bh() is defined as synchronize_rcu(), but > needs to be defined without the parenthesis because the compiler will > complain when synchronize_rcu_bh is referenced as a function pointer > and not a function. > > Signed-off-by: John Kacur <jkacur@redhat.com> > Cc: Paul McKenney <paulmck@linux.vnet.ibm.com> > Cc: stable-rt@vger.kernel.org > Link: http://lkml.kernel.org/r/1321235083-21756-1-git-send-email-jkacur@redhat.com > Signed-off-by: Thomas Gleixner <tglx@linutronix.de> > Signed-off-by: Steven Rostedt <rostedt@goodmis.org>
Reviewed-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> --- > include/linux/rcutree.h | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/include/linux/rcutree.h b/include/linux/rcutree.h > index 7a25aea..3bf47dc 100644 > --- a/include/linux/rcutree.h > +++ b/include/linux/rcutree.h > @@ -60,7 +60,7 @@ static inline void exit_rcu(void) > #ifndef CONFIG_PREEMPT_RT_FULL > extern void synchronize_rcu_bh(void); > #else > -# define synchronize_rcu_bh() synchronize_rcu() > +# define synchronize_rcu_bh synchronize_rcu > #endif > extern void synchronize_sched_expedited(void); > extern void synchronize_rcu_expedited(void); > -- > 1.7.7.1 > >
-- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |