Messages in this thread | | | Date | Sun, 20 Nov 2011 14:28:36 -0800 (PST) | From | David Rientjes <> | Subject | Re: [PATCH] x86, mrst: Casting (void *) value returned by kmalloc is useless |
| |
On Fri, 18 Nov 2011, Pekka Enberg wrote:
> >> diff -u -p a/arch/x86/platform/mrst/mrst.c b/arch/x86/platform/mrst/mrst.c > >> --- a/arch/x86/platform/mrst/mrst.c 2011-11-07 19:37:40.283168752 +0100 > >> +++ b/arch/x86/platform/mrst/mrst.c 2011-11-08 09:19:24.686513740 +0100 > >> @@ -331,7 +331,7 @@ static int __init sfi_parse_gpio(struct > >> num = SFI_GET_NUM_ENTRIES(sb, struct sfi_gpio_table_entry); > >> pentry = (struct sfi_gpio_table_entry *)sb->pentry; > >> > >> - gpio_table = (struct sfi_gpio_table_entry *) > >> + gpio_table = > >> kmalloc(num * sizeof(*pentry), GFP_KERNEL); > > On Fri, Nov 18, 2011 at 12:16 PM, Alan Cox <alan@lxorguk.ukuu.org.uk> wrote: > > True but the formatting also wants fixing with that change. > > A conversion to kcalloc() would make sense as well.
Seems unnecessary to zero the array if it's going to immediately copy the gpio table, though. | |