lkml.org 
[lkml]   [2011]   [Nov]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[091/107] xen/timer: Missing IRQF_NO_SUSPEND in timer code broke suspend.
    2.6.32-longterm review patch.  If anyone has any objections, please let us know.

    ------------------

    From: Ian Campbell <Ian.Campbell@citrix.com>

    commit f611f2da99420abc973c32cdbddbf5c365d0a20c upstream.

    The patches missed an indirect use of IRQF_NO_SUSPEND pulled in via
    IRQF_TIMER. The following patch fixes the issue.

    With this fixlet PV guest migration works just fine. I also booted the
    entire series as a dom0 kernel and it appeared fine.

    Signed-off-by: Ian Campbell <ian.campbell@citrix.com>
    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    arch/x86/xen/time.c | 4 +++-
    1 file changed, 3 insertions(+), 1 deletion(-)

    --- a/arch/x86/xen/time.c
    +++ b/arch/x86/xen/time.c
    @@ -395,7 +395,9 @@ void xen_setup_timer(int cpu)
    name = "<timer kasprintf failed>";

    irq = bind_virq_to_irqhandler(VIRQ_TIMER, cpu, xen_timer_interrupt,
    - IRQF_DISABLED|IRQF_PERCPU|IRQF_NOBALANCING|IRQF_TIMER,
    + IRQF_DISABLED|IRQF_PERCPU|
    + IRQF_NOBALANCING|IRQF_TIMER|
    + IRQF_FORCE_RESUME,
    name, NULL);

    evt = &per_cpu(xen_clock_events, cpu);



    \
     
     \ /
      Last update: 2011-11-03 02:43    [W:0.031 / U:1.196 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site