Messages in this thread | | | Date | Sat, 19 Nov 2011 10:25:25 +0100 | From | Marco Stornelli <> | Subject | Re: [PATCH 2/2] ramoops: remove module parameters |
| |
Il 18/11/2011 20:31, Kees Cook ha scritto: > The ramoops driver is intended to be used with platforms that define > persistent memory regions. If memory regions were configurable with > module parameters, it would be possible to read some RAM regions via > the pstore interface without access to /dev/mem (which would result > in a loss of kernel memory privacy when a system is built with > STRICT_DEVMEM), so remove this ability completely. >
I don't like it very much. The loss of module parameters give us less flexibility. The main goal of this driver is debug, so I think it should be fast to use. I mean it's not more possible reserve a memory region and load the module "on-the-fly", it needs a platform device, it's ok but I think it's a little bit more complicated, (without talking about platforms without a device tree source). I don't understand the problem of strict devmem. We shouldn't use kernel memory region but only reserved ones and the driver doesn't use the request_mem_region_exclusive, am I wrong?
Marco
| |