Messages in this thread |  | | | Date | Sat, 19 Nov 2011 20:30:58 +0400 | | From | Vasiliy Kulikov <> | | Subject | Re: [PATCH 3/3] security: Yama: add ptrace relationship tracking interface |
| |
Hi Kees,
Thank you for working on this! We'll use Yama in Openwall too :-)
On Wed, Oct 26, 2011 at 16:49 -0700, Kees Cook wrote: > + if (mode == PTRACE_MODE_ATTACH && > + ptrace_scope && > + !capable(CAP_SYS_PTRACE) && > + !task_is_descendant(current, child) && > + !ptracer_exception_found(current, child)) > + rc = -EPERM;
capable() is better to put after all other tests as a failed capable() might emit a false positive warning into logs or something.
Thanks,
-- Vasiliy
|  |