lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[07/26] drm/i915: Fix object refcount leak on mmappable size limit error path.
    3.1-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Eric Anholt <eric@anholt.net>

    commit 14660ccd599dc7bd6ecef17408bd76dc853f9b77 upstream.

    I've been seeing memory leaks on my system in the form of large
    (300-400MB) GEM objects created by now-dead processes laying around
    clogging up memory. I usually notice when it gets to about 1.2GB of
    them. Hopefully this clears up the issue, but I just found this bug
    by inspection.

    Signed-off-by: Eric Anholt <eric@anholt.net>
    Signed-off-by: Keith Packard <keithp@keithp.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

    ---
    drivers/gpu/drm/i915/i915_gem.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/gpu/drm/i915/i915_gem.c
    +++ b/drivers/gpu/drm/i915/i915_gem.c
    @@ -1475,7 +1475,7 @@ i915_gem_mmap_gtt(struct drm_file *file,

    if (obj->base.size > dev_priv->mm.gtt_mappable_end) {
    ret = -E2BIG;
    - goto unlock;
    + goto out;
    }

    if (obj->madv != I915_MADV_WILLNEED) {



    \
     
     \ /
      Last update: 2011-11-19 01:37    [W:0.019 / U:91.912 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site