lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH v7 3.2-rc2 19/30] tracing: modify is_delete, is_return from ints to bool.

    is_delete and is_return can take atmost 2 values and
    are better of being a boolean than a int.

    Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
    ---

    Changelog (since v5):
    - extracted from the next patch on Masami's suggestion.

    kernel/trace/trace_kprobe.c | 16 ++++++++--------
    1 files changed, 8 insertions(+), 8 deletions(-)

    diff --git a/kernel/trace/trace_kprobe.c b/kernel/trace/trace_kprobe.c
    index 00d527c..2490dd1 100644
    --- a/kernel/trace/trace_kprobe.c
    +++ b/kernel/trace/trace_kprobe.c
    @@ -651,7 +651,7 @@ static struct trace_probe *alloc_trace_probe(const char *group,
    void *addr,
    const char *symbol,
    unsigned long offs,
    - int nargs, int is_return)
    + int nargs, bool is_return)
    {
    struct trace_probe *tp;
    int ret = -ENOMEM;
    @@ -944,7 +944,7 @@ static int split_symbol_offset(char *symbol, unsigned long *offset)
    #define PARAM_MAX_STACK (THREAD_SIZE / sizeof(unsigned long))

    static int parse_probe_vars(char *arg, const struct fetch_type *t,
    - struct fetch_param *f, int is_return)
    + struct fetch_param *f, bool is_return)
    {
    int ret = 0;
    unsigned long param;
    @@ -977,7 +977,7 @@ static int parse_probe_vars(char *arg, const struct fetch_type *t,

    /* Recursive argument parser */
    static int __parse_probe_arg(char *arg, const struct fetch_type *t,
    - struct fetch_param *f, int is_return)
    + struct fetch_param *f, bool is_return)
    {
    int ret = 0;
    unsigned long param;
    @@ -1089,7 +1089,7 @@ static int __parse_bitfield_probe_arg(const char *bf,

    /* String length checking wrapper */
    static int parse_probe_arg(char *arg, struct trace_probe *tp,
    - struct probe_arg *parg, int is_return)
    + struct probe_arg *parg, bool is_return)
    {
    const char *t;
    int ret;
    @@ -1162,7 +1162,7 @@ static int create_trace_probe(int argc, char **argv)
    */
    struct trace_probe *tp;
    int i, ret = 0;
    - int is_return = 0, is_delete = 0;
    + bool is_return = false, is_delete = false;
    char *symbol = NULL, *event = NULL, *group = NULL;
    char *arg;
    unsigned long offset = 0;
    @@ -1171,11 +1171,11 @@ static int create_trace_probe(int argc, char **argv)

    /* argc must be >= 1 */
    if (argv[0][0] == 'p')
    - is_return = 0;
    + is_return = false;
    else if (argv[0][0] == 'r')
    - is_return = 1;
    + is_return = true;
    else if (argv[0][0] == '-')
    - is_delete = 1;
    + is_delete = true;
    else {
    pr_info("Probe definition must be started with 'p', 'r' or"
    " '-'.\n");


    \
     
     \ /
      Last update: 2011-11-18 12:39    [W:0.024 / U:213.728 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site