lkml.org 
[lkml]   [2011]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] mm: remove struct reclaim_state
Dave Chinner wrote:
> On Fri, Nov 18, 2011 at 01:28:06PM +0300, Konstantin Khlebnikov wrote:
>> Memory reclaimer want to know how much pages was reclaimed during shrinking slabs.
>> Currently there is special struct reclaim_state with single counter and pointer from
>> task-struct. Let's store counter direcly on task struct and account freed pages
>> unconditionally. This will reduce stack usage and simplify code in reclaimer and slab.
>>
>> Logic in do_try_to_free_pages() is slightly changed, but this is ok.
>> Nobody calls shrink_slab() explicitly before do_try_to_free_pages(),
>
> Except for drop_slab() and shake_page()....

Indeed, but they do not care about accounting reclaimed pages and
they do not call do_try_to_free_pages() after all.

>
> Cheers,
>
> Dave.



\
 
 \ /
  Last update: 2011-11-18 11:09    [from the cache]
©2003-2011 Jasper Spaans