Messages in this thread | | | Subject | Re: [PATCHv3 06/10] x86, perf: disable non available architectural events. | From | Peter Zijlstra <> | Date | Thu, 17 Nov 2011 10:29:34 +0100 |
| |
On Thu, 2011-11-10 at 14:57 +0200, Gleb Natapov wrote: > + > + /* disable event that reported as not presend by cpuid */ > + for_each_set_bit(bit, x86_pmu.events_mask, > + min(x86_pmu.events_mask_len, x86_pmu.max_events)) > + intel_perfmon_event_map[intel_event_id_to_hw_id[bit]] = 0;
I think that should read:
for_each_set_bit(bit, x86_pmu.events_mask, ARRAY_SIZE(intel_event_id_to_hw_id)) intel_perfmon_event_map[intel_event_id_to_hw_id[bit]] = 0;
There is no guarantee x86_pmu.max_events has any relation to the size of intel_event_id_to_hw_id.
Changed it for you.
| |