Messages in this thread | | | Date | Thu, 17 Nov 2011 16:01:16 +0800 | Subject | Re: [PATCH 2/2] lockdep: print lock name for lockdep_init_error | From | Ming Lei <> |
| |
Hi,
Thanks for your review.
On Thu, Nov 17, 2011 at 2:02 PM, Yong Zhang <yong.zhang0@gmail.com> wrote: > On Thu, Nov 17, 2011 at 01:34:32PM +0800, tom.leiming@gmail.com wrote: >> From: Ming Lei <tom.leiming@gmail.com> >> >> This patch prints the name of the lock which is acquired >> before lockdep_init is called, so that user can easily find >> which lock trigged the lockdep init error warning. > > Should we care about that?
Yes, we should, see below.
> > I think lockdep_init() called early enough give more hint. > Such as be the first C function called by arch.
Maybe not early enough, before start_kernel is executed, arch asm code still can call some C function, can't it?
The patch is just an improvement on original lockdep_init_error detect, plus fix on incorrect debug message.
thanks, -- Ming Lei
| |