Messages in this thread | | | Date | Thu, 17 Nov 2011 16:31:32 -0800 | Subject | Re: [PATCH] ahci: platform support for suspend/resume | From | Brian Norris <> |
| |
+linux-pm mailing list
Hi Felipe,
On Wed, Nov 16, 2011 at 12:34 PM, Felipe Balbi <balbi@ti.com> wrote: > On Wed, Nov 16, 2011 at 12:27:59PM -0800, Brian Norris wrote: >> + /* Does platform support suspend/resume? */ >> + if (!pdata->suspend || !pdata->resume) >> + return -EINVAL; > > should you really prevent suspend is platform doesn't provide > ->suspend() ?
No, we shouldn't prevent suspend entirely; that would just be my accidental side effect.
> I mean, we could some platform where all clocks are autogated and > there's no need for platform to do anything. Would it be better to only > call pdata->suspend if it exists but still let the AHCI-specific part go > through ?
Perhaps. But would this have any unintended effects on systems that don't implement AHCI power management at all? My intention was just to provide an 'opt-in' interface for platform developers. I probably got this wrong.
Brian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |