Messages in this thread Patch in this message | | | From | "Rafael J. Wysocki" <> | Subject | [PATCH] PM / Sleep: Remove pm_runtime_suspended() from __pm_generic_call() | Date | Fri, 18 Nov 2011 00:37:22 +0100 |
| |
From: Rafael J. Wysocki <rjw@sisk.pl>
The pm_runtime_suspended() check in __pm_generic_call() doesn't really help and may cause problems to happen, because in some cases the system suspend callbacks need to be called even if the given device has been suspended by runtime PM. For example, if the device generally supports remote wakeup and is not enabled to wake up the system from sleep, it should be prevented from generating wakeup signals during system suspend and that has to be done by the suspend callbacks that the pm_runtime_suspended() check prevents from being executed. For this reason, remove the pm_runtime_suspended() check from __pm_generic_call().
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl> --- drivers/base/power/generic_ops.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/base/power/generic_ops.c =================================================================== --- linux.orig/drivers/base/power/generic_ops.c +++ linux/drivers/base/power/generic_ops.c @@ -106,7 +106,7 @@ static int __pm_generic_call(struct devi const struct dev_pm_ops *pm = dev->driver ? dev->driver->pm : NULL; int (*callback)(struct device *); - if (!pm || pm_runtime_suspended(dev)) + if (!pm) return 0; switch (event) {
| |