Messages in this thread | | | Date | Thu, 17 Nov 2011 20:19:06 -0300 | From | Cristian Rodríguez <> | Subject | Re: [opensuse-kernel] Re: [PATCH] include/log2.h: Fix rounddown_pow_of_two(1) |
| |
On 17/11/11 20:05, Andrew Morton wrote:
> I assume that nobody has gone off and checked whether all current > callers will survive this change. If they had, they'd have looked in > drivers/char/ramoops.c and seen: > > rounddown_pow_of_two(pdata->mem_size); > rounddown_pow_of_two(pdata->record_size); > > These operations are no-ops. It should be > > pdata->mem_size = rounddown_pow_of_two(pdata->mem_size); > pdata->record_size = rounddown_pow_of_two(pdata->record_size); > > That we have this many warts using these interfaces is an indication > that the interfaces aren't very good. Poorly documented, at least. >
making that macro an inline function and annotating with __attribute__((warn_unused_result)) looks like a good start for me.
| |