[lkml]   [2011]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH] m68k: Remove references to obsolete CONFIG_SERIAL167
    On Thu, 2011-11-17 at 22:05 +0100, Geert Uytterhoeven wrote:
    > > Why do you care about SERIAL_CONSOLE? If it's only really used by
    > > AMIGA_BUILTIN_SERIAL why shouldn't we rename it to
    > Because SERIAL_CONSOLE is a universal platform-independent symbol.
    > Other arches have it as well (but less than in the past).
    > As soon as m68k gets a new serial driver, it will be used by 2 drivers again.

    If one does
    $ git grep -n "\<\(CONFIG_\)\?SERIAL_CONSOLE\>" | grep -v defconfig

    one gets a few hits (summarized):
    - arch/m68k/Kconfig.devices: discussed here;
    - arch/sparc/Kconfig: apparently unused, and can be dropped;
    - arch/xtensa/Kconfig and arch/xtensa/platforms/iss/console.c: the only
    other current usage (note that the "S6105" platform, mentioned in the
    Kconfig file, seems not to use it);
    - drivers/staging/serial/68360serial.c: uses CONFIG_SERIAL_CONSOLE, but
    I don't see how it can actually be set for that driver;
    - drivers/tty/amiserial.c: discussed here.

    I see nothing universal about it: two independent usages, one in
    */iss/console.c and one in */amiserial.c. So I'd say these can be

    Paul Bolle

     \ /
      Last update: 2011-11-17 22:37    [W:0.019 / U:51.796 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site