lkml.org 
[lkml]   [2011]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/platform: (TS-5500) fix CONFIG_TS5500_ADC dependency
On Thu, 17 Nov 2011 10:39:06 -0800,
"H. Peter Anvin" <hpa@zytor.com> wrote:

> On 11/17/2011 10:36 AM, Vivien Didelot wrote:
> > Hi Ingo,
> >
> > Here's the fix for the Kconfig dependency issue, for the TS-5500
> > platform. It is based on the latest x86/platform branch from the
> > -tip tree.
> >
> > Best,
> >
> > Vivien
> >
> > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > ---
> > arch/x86/platform/ts5500/Kconfig | 2 +-
> > 1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/x86/platform/ts5500/Kconfig
> > b/arch/x86/platform/ts5500/Kconfig index be51b86..84e59a9 100644
> > --- a/arch/x86/platform/ts5500/Kconfig
> > +++ b/arch/x86/platform/ts5500/Kconfig
> > @@ -23,6 +23,6 @@ config TS5500_LED
> >
> > config TS5500_ADC
> > bool "TS-5500 ADC"
> > - depends on TS5500
> > + depends on TS5500 && HWMON=y
> > help
> > Support for the A/D converter on Technologic Systems TS-5500
> > SBCs.
>
> Shouldn't this be a module, too?
>
> -hpa
>

IMHO it would be overkill for such a small embedded platform to provide
device drivers as modules.

Regards,

Vivien


\
 
 \ /
  Last update: 2011-11-17 19:59    [from the cache]
©2003-2011 Jasper Spaans