Messages in this thread | | | Date | Thu, 17 Nov 2011 18:03:46 +0100 | From | Tomasz Buchert <> | Subject | Re: [PATCH] cgroup_freezer: fix freezing groups with stopped tasks |
| |
Le 17/11/2011 17:13, Michal Hocko a écrit : > On Thu 17-11-11 11:14:53, Tomasz Buchert wrote: >> Hi, >> I'm trying to understand now why I did that change in >> >> 2d3cbf8bc (the bug itself was in the if-the-else clause in >> update_if_frozen , anyway). >> Well, when I look at this now I think that there is nothing wrong >> with your patch. >> You can try my testcases from 2d3cbf8bc and 0bdba580, but it should be ok. > Yes, I have tried it before sending the patch. > >> One thing I am not sure completely of is the following situation. So >> the group is frozen >> with the STOPPED task inside. There are few questions: >> * if you send SIGCONT to the task now, will it wake up? > No, it will enter refrigerator and wake up on thawing the group. Check > out `goto relock' after do_signal_stop returns. > I've checked your patch empirically few hours before :). Also I've read get_signal_to_deliver() and you are right - it's gonna be fine. The decision is not mine, of course, but I suggest to merge it. Good work!
Tomek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |