lkml.org 
[lkml]   [2011]   [Nov]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [GIT PULL] Queue free fix (was Re: [PATCH] block: Free queue resources at blk_release_queue())
    On Thu, Nov 10 2011 at 11:10am -0500,
    Heiko Carstens <heiko.carstens@de.ibm.com> wrote:

    > On Wed, Nov 09, 2011 at 10:37:06AM +0100, Hannes Reinecke wrote:

    ...

    > > Hmm. Just to be on the safe side, could you try this one:
    > >
    > > diff --git a/drivers/md/dm-mpath.c b/drivers/md/dm-mpath.c
    > > index 5e0090e..e6fad46 100644
    > > --- a/drivers/md/dm-mpath.c
    > > +++ b/drivers/md/dm-mpath.c
    > > @@ -920,8 +920,10 @@ static int multipath_map(struct dm_target *ti,
    > > struct reque
    > > st *clone,
    > > map_context->ptr = mpio;
    > > clone->cmd_flags |= REQ_FAILFAST_TRANSPORT;
    > > r = map_io(m, clone, mpio, 0);
    > > - if (r < 0 || r == DM_MAPIO_REQUEUE)
    > > + if (r < 0 || r == DM_MAPIO_REQUEUE) {
    > > mempool_free(mpio, m->mpio_pool);
    > > + map_context->ptr = NULL;
    > > + }
    > >
    > > return r;
    > > }
    >
    > With your patch we haven't been able to reproduce the kernel crash until now.
    > Now we "only" run into I/O stalls, which before your patch we also did. But
    > repeatedly rebooting and retrying and ignoring the I/O stalls always lead to
    > a crash.
    > Gonzalo will run a couple of extra rounds so we can have a feeling if at least
    > one of the bugs could be fixed with your patch ;)

    Hi,

    Any update after further testing with Hannes' patch?


    \
     
     \ /
      Last update: 2011-11-17 17:31    [W:5.682 / U:0.244 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site