Messages in this thread | | | Date | Wed, 16 Nov 2011 10:19:10 +0200 | From | Denis Kuzmenko <> | Subject | Re: [PATCH] gpio: add flags to export GPIOs when requesting |
| |
Hi Stephen,
On 11/16/2011 01:32 AM, Stephen Warren wrote: > Denis Kuzmenko wrote at Tuesday, November 15, 2011 4:05 PM: >> Hi Wolfram, >> On 11/16/2011 12:44 AM, Wolfram Sang wrote: >> >> #define GPIOF_EXPORT (1 << 2) >> #define GPIOF_EXPORT_DIR_CHANGEABLE (3 << 2) > > Then you won't have a single flag to check if the dir is changeable. > > Personally, I'd go for the two single-bit flags, and force boards to OR > them together if they want the GPIO exported and with a changeable > direction; just get rid of the two _DIR_ flags. That said, Wolfram's > patch seems to follow the conventions already in the file.
Your truth.
> Dong Aisheng posted patch "gpio: introduce gpio_export_array to ease > export for gpio arrays". Which should we pick; it doesn't seem like we > need both mechanisms.
I vote for GPIOF_* variant (this one) since it can deal with different settings for each gpio pin in array.
-- Best regards, Denis Kuzmenko.
| |