lkml.org 
[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] fix typo/thinko in get_random_bytes()
On 11/16/2011 10:50 AM, Luck, Tony wrote:
> If there is an architecture-specific random number generator we use
> it to acquire randomness one "long" at a time. We should put these
> random words into consecutive words in the result buffer - not just
> overwrite the first word again and again.
>
> Signed-off-by: Tony Luck <tony.luck@intel.com>

Ouch. Good catch. This, I guess, is the downside of doing this only on
the kernel paths... made this kind of errors harder to catch.

Acked-by: H. Peter Anvin <hpa@zytor.com>

Linus, do you want to take this one or should I put it in the urgent
queue in tip?

-hpa

--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.



\
 
 \ /
  Last update: 2011-11-16 20:37    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site