[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 2/7] regmap: Make reg_config reg_defaults const
On Wed, Nov 16, 2011 at 06:01:40PM +0100, Lars-Peter Clausen wrote:
> On 11/16/2011 05:51 PM, Mark Brown wrote:

> > None of them, I just changed the code to make the defaults const - I'm
> > just reviewing by eyeball as I'm well aware of the fact that this isn't
> > const.

> So you only applied part of the patch and are complaining that it you get an
> error?

I'm saying that the way we're using the reg_defaults is unfortunately
excessively cute right now so just by looking at the code I'm able to
see that there's an issue having done the same change before but not
applied it due to the cuteness. I only did a code mod to generate the
warnings since you weren't seeing any issue.

 \ /
  Last update: 2011-11-16 18:11    [W:0.061 / U:0.100 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site