lkml.org 
[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 8/8] serial: 8250: fix comment about accessing EMSR
    Date
    All docs I checked do say LCR should NOT be 0xBF (16c850, 16c854,
    16v2750). Fix it according to that, since the only usage of the register
    currently implements the revised access method. If somebody later finds
    a derivate which actually does need 0xBF to enable that register, we can
    update the comment again with precise references.

    Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
    ---
    include/linux/serial_reg.h | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/include/linux/serial_reg.h b/include/linux/serial_reg.h
    index 0267bab6..0a1beca 100644
    --- a/include/linux/serial_reg.h
    +++ b/include/linux/serial_reg.h
    @@ -211,7 +211,7 @@
    #define UART_FCTR_TX 0x80 /* Programmable trigger mode select */

    /*
    - * LCR=0xBF, FCTR[6]=1
    + * LCR!=0xBF (some docs say =0), FCTR[6]=1, XR16C85x
    */
    #define UART_EMSR 7 /* Extended Mode Select Register */
    #define UART_EMSR_FIFO_COUNT 0x01 /* Rx/Tx select */
    --
    1.7.7.1


    \
     
     \ /
      Last update: 2011-11-16 17:27    [W:0.021 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site