[lkml]   [2011]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 2/7] regmap: Make reg_config reg_defaults const
    On 11/16/2011 05:13 PM, Mark Brown wrote:
    > On Wed, Nov 16, 2011 at 04:28:17PM +0100, Lars-Peter Clausen wrote:
    >> The reg_defaults field usually points to a static per driver array, which should
    >> not be modified. Make requirement this explicit by making reg_defaults const.
    > You should've got reams of sparse warnings from that - the indexed cache
    > is writing to the defaults table (which is very naughty and i keep
    > thinking about deleting it as a result).

    This patch makes reg_defaults const in the reg_config struct not in the
    regmap struct.

    Since we duplicate the reg_config reg_defaults into the regmap reg_defaults
    the index cache works on a runtime allocated array. (Though I wouldn't
    object to see it gone. For the average uscase it uses more memory and is
    slower than the rbnode cache).

    - Lars

     \ /
      Last update: 2011-11-16 17:25    [W:0.025 / U:52.188 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site