Messages in this thread | | | From | Rabin Vincent <> | Date | Wed, 16 Nov 2011 21:05:02 +0530 | Subject | Re: [PATCH 1/5] mfd/stmpe: Pass partnum as param to stmpe_probe() |
| |
On Wed, Nov 16, 2011 at 16:56, Viresh Kumar <viresh.kumar@st.com> wrote: > partnum is required during probe to get variant's info. Currently partnum was > getting set in i2c interface after it is used and is not at all getting set in > spi interface.
So your previous patch is broken? Please fix it and resend it instead since it's not merged yet.
> > This can be passed as param to stmpe_probe, so that it is available early. With > this, there is no need of i2c interface's init() routine, as it does nothing > else than calling dev_set_drvdata(). So better remove this routine for i2c. > > partnum defined in struct stmpe is of no use now, as it is only used once during > probe of stmpe, so we can remove it from struct stmpe too.
Not quite; it's used from drivers/input/keyboard/stmpe-keypad.c. Please preserve this stmpe->partnum, drop your 2/5 patch which exposes variant externally, and instead use stmpe->partnum in 5/5.
| |