lkml.org 
[lkml]   [2011]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 4/4] mmc: Add mmc_host_<level> logging
    From
    Date
    On Wed, 2011-11-16 at 10:14 +0900, NamJae Jeon wrote:
    > 2011/11/16 Joe Perches <joe@perches.com>:
    > > On Wed, 2011-11-16 at 09:52 +0900, NamJae Jeon wrote:
    > >> 2011/11/16 Joe Perches <joe@perches.com>:
    > >> > Centralize the pr_<level> uses of mmc_hostname into specific
    > >> > mmc_host_<level> calls to allow a flexible presentation style
    > >> > and shorten the code a bit.
    > >> I don't know why pr_info should be surely replaced by mmc_host_info.
    > >> if it is needed for only host name, I think that existing
    > >> pr_info/err/debug is sufficient.
    > > Please trim your replies and read the patch description.
    > my concern is that they feel confuse when coder add print code because
    > they should use mmc_host<level> for hostname, and pr_<level> is used
    > in the other case.

    That's one point of view.

    It is the same issue though as using dev_<level>
    when you have a struct device * and also using
    pr_<level> otherwise.



    \
     
     \ /
      Last update: 2011-11-16 02:21    [W:0.025 / U:29.288 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site