Messages in this thread | | | Date | Tue, 15 Nov 2011 14:33:59 -0800 | From | Stephen Hemminger <> | Subject | Re: [PATCH net-next v4 4/8] forcedeth: expose module parameters in /sys/module |
| |
On Tue, 15 Nov 2011 11:25:37 -0800 David Decotigny <david.decotigny@google.com> wrote:
> +module_param(msi, int, S_IRUGO); > MODULE_PARM_DESC(msi, "MSI interrupts are enabled by setting to 1 and disabled by setting to 0."); > -module_param(msix, int, 0); > +module_param(msix, int, S_IRUGO); > MODULE_PARM_DESC(msix, "MSIX interrupts are enabled by setting to 1 and disabled by setting to 0."); > -module_param(dma_64bit, int, 0); > +module_param(dma_64bit, int, S_IRUGO);
Once again these attributes are visible through other means (/proc/interrupts for MSI) and the 64bit dma is NETIF_F_HIGHDMA. They shouldn't be module parameters.
| |