Messages in this thread | | | Date | Tue, 15 Nov 2011 11:34:04 +0530 | From | "Srivatsa S. Bhat" <> | Subject | Re: [PATCH v2] kernel/cpu.c: Add right qualifiers for alloc_frozen_cpus() and cpu_hotplug_pm_sync_init() |
| |
On 11/15/2011 05:27 AM, Fenghua Yu wrote: > From: Fenghua Yu <fenghua.yu@intel.com> > > Add __init for functions alloc_frozen_cpus() and cpu_hotplug_pm_sync_init() > because they are only called during boot time. > > Add static for function cpu_hotplug_pm_sync_init() because its scope is limited > in this file only. > > Signed-off-by: Fenghua Yu <fenghua.yu@intel.com>
Acked-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
Thanks, Srivatsa S. Bhat
> --- > v2: Change a function name typo in the title. > > kernel/cpu.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/cpu.c b/kernel/cpu.c > index 563f136..cf915b8 100644 > --- a/kernel/cpu.c > +++ b/kernel/cpu.c > @@ -470,7 +470,7 @@ out: > cpu_maps_update_done(); > } > > -static int alloc_frozen_cpus(void) > +static int __init alloc_frozen_cpus(void) > { > if (!alloc_cpumask_var(&frozen_cpus, GFP_KERNEL|__GFP_ZERO)) > return -ENOMEM; > @@ -543,7 +543,7 @@ cpu_hotplug_pm_callback(struct notifier_block *nb, > } > > > -int cpu_hotplug_pm_sync_init(void) > +static int __init cpu_hotplug_pm_sync_init(void) > { > pm_notifier(cpu_hotplug_pm_callback, 0); > return 0;
| |