lkml.org 
[lkml]   [2011]   [Nov]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] media: fix truncated entity specification
Laurent Pinchart wrote:
> On Saturday 05 November 2011 22:42:01 Clemens Ladisch wrote:
> > When enumerating an entity, assign the entire entity specification
> > instead of only the first two words. (This requires giving the
> > specification union a name.)
>
> What about this (untested) simpler patch ?
>
> - u_ent.v4l.major = ent->v4l.major;
> - u_ent.v4l.minor = ent->v4l.minor;
> + memcpy(&u_ent.raw, &ent->raw, sizeof(u_ent.raw));

I would have written it this way if ent->raw actually existed.
(And please don't tell me you want to increase the size of
struct media_entity by 172 bytes. :)


Regards,
Clemens


\
 
 \ /
  Last update: 2011-11-15 14:05    [W:0.046 / U:24.704 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site