[lkml]   [2011]   [Nov]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    Patch in this message
    Subject[PATCH 1/5] regmap: return ERR_PTR instead of NULL in regmap_init
    The regmap_init documentation states that it will either return a pointer to a
    valid regmap structure or a ERR_PTR in case of an error. Currently it returns a
    NULL pointer in case no bus or no config was given. Since NULL is not a
    ERR_PTR a caller might assume that it is a pointer to a valid regmap structure,
    so return a ERR_PTR(-EINVAL) instead.

    Signed-off-by: Lars-Peter Clausen <>
    drivers/base/regmap/regmap.c | 2 +-
    1 files changed, 1 insertions(+), 1 deletions(-)

    diff --git a/drivers/base/regmap/regmap.c b/drivers/base/regmap/regmap.c
    index b08df85..b84ebf9 100644
    --- a/drivers/base/regmap/regmap.c
    +++ b/drivers/base/regmap/regmap.c
    @@ -139,7 +139,7 @@ struct regmap *regmap_init(struct device *dev,
    int ret = -EINVAL;

    if (!bus || !config)
    - return NULL;
    + goto err;

    map = kzalloc(sizeof(*map), GFP_KERNEL);
    if (map == NULL) {

     \ /
      Last update: 2011-11-14 10:41    [W:0.020 / U:13.824 seconds]
    ©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site