Messages in this thread | | | Date | Mon, 14 Nov 2011 21:41:51 -0500 (EST) | Subject | Re: [PATCH 5/5] net-next:asix: update VERSION and white space changes | From | David Miller <> |
| |
From: David Miller <davem@davemloft.net> Date: Mon, 14 Nov 2011 21:32:55 -0500 (EST)
> From: Grant Grundler <grundler@chromium.org> > Date: Mon, 14 Nov 2011 16:54:35 -0800 > >> On Mon, Nov 14, 2011 at 3:42 PM, David Miller <davem@davemloft.net> wrote: >> ... >>> Please, just submit this without the whitespace and other cleanup >>> stuff. Restrict it to real bug fixes, and I'll push it around. >> >> I just sent a "v2" of 5/5 patch which only has the VERSION change. Is >> that sufficient or should I resend all 5? > > Just respinning #5 is fine, thanks.
But the fact that the other bits don't even compile... that's not fine.
drivers/net/usb/asix.c: In function ‘ax88178_bind’: drivers/net/usb/asix.c:1463:2: error: implicit declaration of function ‘ax88178_sw_reset’ [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors
[davem@boricha net]$ git grep ax88178_sw_reset drivers/net/usb/asix.c: ax88178_sw_reset(dev, 0);
Come on man... are you kidding me?
| |