Messages in this thread | | | Date | Mon, 14 Nov 2011 13:21:40 -0800 (PST) | From | Andrei Warkentin <> | Subject | Re: [PATCH] /dev/mem: Fix wrong error on accessing beyond valid memory addresses. |
| |
Hi Peter,
----- Original Message ----- > From: "Andrei Warkentin" <andreiw@vmware.com> > To: linux-kernel@vger.kernel.org > Cc: "Andrei Warkentin" <andreiw@vmware.com>, "H. Peter Anvin" <hpa@zytor.com> > Sent: Wednesday, November 9, 2011 6:31:19 PM > Subject: [PATCH] /dev/mem: Fix wrong error on accessing beyond valid memory addresses. > > Currently this returns -EFAULT, but it really should be returning 0, > as in - 0 bytes read or written. This is what you would get by > opening a block device, seeking to the end, and trying to read > something. Additionally, make lseek() check the sought-to offset > to pass the valid_phys_addr_range test. > > Cc: H. Peter Anvin <hpa@zytor.com> > Signed-off-by: Andrei Warkentin <andreiw@vmware.com> > ---
I know you're very busy, but I was wondering if you could give your two cents on this change. This change grew from our discussion on LKML last week.
Thanks ahead, A
| |