Messages in this thread Patch in this message | | | From | Anders Larsen <> | Subject | [PATCH -next] qnx4fs: Use kmemdup rather than duplicating its implementation | Date | Sun, 13 Nov 2011 18:47:49 +0100 |
| |
From: Thomas Meyer <thomas@m3y3r.de>
Use kmemdup rather than duplicating its implementation
The semantic patch that makes this change is available in scripts/coccinelle/api/memdup.cocci.
Signed-off-by: Thomas Meyer <thomas@m3y3r.de> Signed-off-by: Anders Larsen <al@alarsen.net> ---
diff -u -p a/fs/qnx4/inode.c b/fs/qnx4/inode.c --- a/fs/qnx4/inode.c 2011-11-07 19:38:23.987165894 +0100 +++ b/fs/qnx4/inode.c 2011-11-08 10:33:59.882543999 +0100 @@ -199,12 +199,13 @@ static const char *qnx4_checkroot(struct if (!strcmp(rootdir->di_fname, QNX4_BMNAME)) { found = 1; - qnx4_sb(sb)->BitMap = kmalloc( sizeof( struct qnx4_inode_entry ), GFP_KERNEL ); + qnx4_sb(sb)->BitMap = kmemdup(rootdir, + sizeof(struct qnx4_inode_entry), + GFP_KERNEL); if (!qnx4_sb(sb)->BitMap) { brelse (bh); return "not enough memory for bitmap inode"; - } - memcpy( qnx4_sb(sb)->BitMap, rootdir, sizeof( struct qnx4_inode_entry ) ); /* keep bitmap inode known */ + }/* keep bitmap inode known */ break; } }
| |