Messages in this thread | | | Subject | Re: [PATCH v2 07/16] mtd/docg3: add OOB layout to mtdinfo | From | Artem Bityutskiy <> | Date | Sun, 13 Nov 2011 14:53:43 +0200 |
| |
On Sun, 2011-11-13 at 11:18 +0100, Robert Jarzmik wrote: > I personally think this should be provided by the MTD API. A function > is_page_blank(ofs) could tell if the page was written or not. Now if the > function is NULL, the upper layer (UBIFS, ...) could decide _by itself_ to > assign a free OOB byte to that meaning. But IMHO it's not the drivers duty to > take these decisions to restrict the OOB, let it be done at an upper level.
Probably it is a good idea to introduce an mtd_is_page_blank. But it should either work for all flashes or not introduced at all. I do not think upper layers should use OOB at all. And this interface should also work for NOR flash. Probably it should just fall-back to comparing the data with 0xFF if the driver cannot offer anything special.
Artem.
| |