lkml.org 
[lkml]   [2011]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRE: [PATCH] fsl-rio: fix compile error
    Date
    Yes, I'm afraid srio was not enabled when you compiled.

    Regards,

    Liu Gang
    -----Original Message-----
    From: Paul Gortmaker [mailto:paul.gortmaker@windriver.com]
    Sent: Friday, November 11, 2011 11:48 PM
    To: Liu Gang-B34182
    Cc: linuxppc-dev@lists.ozlabs.org; Alexandre.Bounine@idt.com; akpm@linux-foundation.org; linux-kernel@vger.kernel.org; Li Yang-R58472; Gala Kumar-B11780; Zang Roy-R61911
    Subject: Re: [PATCH] fsl-rio: fix compile error

    On 11-11-11 08:48 AM, Liu Gang wrote:
    > The "#include <linux/module.h>" was replaced by "#include <linux/export.h>"
    > in the patch "powerpc: various straight conversions from module.h --> export.h".
    > This will cause the following compile problem:
    > arch/powerpc/sysdev/fsl_rio.c: In function 'fsl_rio_mcheck_exception':
    > arch/powerpc/sysdev/fsl_rio.c:296: error: implicit declaration of function 'search_exception_tables'.
    >
    > The file fsl_rio.c needs the declaration of function "search_exception_tables"
    > in the header file "linux/module.h".

    Thanks -- not sure why this never showed up in my builds of all the powerpc configs, _or_ the linux-next builds. Maybe srio isn't enabled in any of them?

    In any case it looks fine to me. Having the search_exception_tables live in module.h seems odd, but that is an independent issue for later.

    I can queue this unless someone else has already done so.

    Paul.

    >
    > Signed-off-by: Liu Gang <Gang.Liu@freescale.com>
    > ---
    > arch/powerpc/sysdev/fsl_rio.c | 2 +-
    > 1 files changed, 1 insertions(+), 1 deletions(-)
    >
    > diff --git a/arch/powerpc/sysdev/fsl_rio.c
    > b/arch/powerpc/sysdev/fsl_rio.c index de170fd..22ffccd 100644
    > --- a/arch/powerpc/sysdev/fsl_rio.c
    > +++ b/arch/powerpc/sysdev/fsl_rio.c
    > @@ -23,7 +23,7 @@
    > */
    >
    > #include <linux/init.h>
    > -#include <linux/export.h>
    > +#include <linux/module.h>
    > #include <linux/types.h>
    > #include <linux/dma-mapping.h>
    > #include <linux/interrupt.h>




    \
     
     \ /
      Last update: 2011-11-12 06:47    [W:0.025 / U:59.936 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site