lkml.org 
[lkml]   [2011]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v3 1/3] virtio_console: Fix locking of vtermno.
    Date
    On Tue, 08 Nov 2011 13:44:58 -0800, Miche Baker-Harvey <miche@google.com> wrote:
    > Some modifications of vtermno were not done under the spinlock.
    >
    > Moved assignment from vtermno and increment of vtermno together,
    > putting both under the spinlock. Revert vtermno on failure.
    >
    > Signed-off-by: Miche Baker-Harvey <miche@google.com>

    Does it matter? It's normal not to lock in a function called
    "init_XXX", since it's not exposed yet.

    Or is it?

    Thanks,
    Rusty.


    \
     
     \ /
      Last update: 2011-11-11 05:31    [W:5.287 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site