lkml.org 
[lkml]   [2011]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Date
Subject[PATCH v6 3.2-rc1 28/28] uprobes: introduce UTASK_SSTEP_TRAPPED logic

Add UTASK_SSTEP_TRAPPED state/code to handle the case when
xol insn itself triggers the signal.

In this case we should restart the original insn even if the task is
already SIGKILL'ed (say, the coredump should report the correct ip).
This is even more important if the task has a handler for SIGSEGV/etc,
The _same_ instruction should be repeated again after return from the
signal handler, and SSTEP can never finish in this case.

Change uprobe_deny_signal() to set UTASK_SSTEP_TRAPPED and TIF_UPROBE. It
also sets TIF_NOTIFY_RESUME.

When uprobe_notify_resume() sees UTASK_SSTEP_TRAPPED it does abort_xol()
instead of post_xol().

Original-patch-from: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
---
include/linux/uprobes.h | 2 ++
kernel/uprobes.c | 18 +++++++++++++++---
2 files changed, 17 insertions(+), 3 deletions(-)
diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h
index 8d12c06..cd522b8 100644
--- a/include/linux/uprobes.h
+++ b/include/linux/uprobes.h
@@ -76,6 +76,7 @@ enum uprobe_task_state {
UTASK_BP_HIT,
UTASK_SSTEP,
UTASK_SSTEP_ACK,
+ UTASK_SSTEP_TRAPPED,
};

/*
@@ -130,6 +131,7 @@ extern int uprobe_post_notifier(struct pt_regs *regs);
extern int uprobe_bkpt_notifier(struct pt_regs *regs);
extern void uprobe_notify_resume(struct pt_regs *regs);
extern bool uprobe_deny_signal(void);
+extern void __weak abort_xol(struct pt_regs *regs, struct uprobe_task *utask);
#else /* CONFIG_UPROBES is not defined */
static inline int register_uprobe(struct inode *inode, loff_t offset,
struct uprobe_consumer *consumer)
diff --git a/kernel/uprobes.c b/kernel/uprobes.c
index c7de542..a45089c 100644
--- a/kernel/uprobes.c
+++ b/kernel/uprobes.c
@@ -1329,11 +1329,22 @@ bool uprobe_deny_signal(void)
spin_lock_irq(&tsk->sighand->siglock);
clear_tsk_thread_flag(tsk, TIF_SIGPENDING);
spin_unlock_irq(&tsk->sighand->siglock);
+
+ if (__fatal_signal_pending(tsk) || xol_was_trapped(tsk)) {
+ utask->state = UTASK_SSTEP_TRAPPED;
+ set_tsk_thread_flag(tsk, TIF_UPROBE);
+ set_tsk_thread_flag(tsk, TIF_NOTIFY_RESUME);
+ }
}

return true;
}

+void __weak abort_xol(struct pt_regs *regs, struct uprobe_task *utask)
+{
+ set_instruction_pointer(regs, utask->vaddr);
+}
+
/*
* uprobe_notify_resume gets called in task context just before returning
* to userspace.
@@ -1386,6 +1397,8 @@ void uprobe_notify_resume(struct pt_regs *regs)
u = utask->active_uprobe;
if (utask->state == UTASK_SSTEP_ACK)
post_xol(u, regs);
+ else if (utask->state == UTASK_SSTEP_TRAPPED)
+ abort_xol(regs, utask);
else
WARN_ON_ONCE(1);

@@ -1409,9 +1422,8 @@ void uprobe_notify_resume(struct pt_regs *regs)
if (u) {
put_uprobe(u);
set_instruction_pointer(regs, probept);
- } else {
- /*TODO Return SIGTRAP signal */
- }
+ } else
+ send_sig(SIGTRAP, current, 0);
}

/*

\
 
 \ /
  Last update: 2011-11-10 20:11    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site