lkml.org 
[lkml]   [2011]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 4/4] ata: add ata port runtime PM callbacks
On Thu, Nov 10, 2011 at 10:40:21AM -0500, Alan Stern wrote:
> Are you really sure you want to keep this flag set throughout the
> lifetime of the port?
>
> What happens if a command fails, then the port suspends, and then the
> error handler is invoked to take care of the failed command?

Runtime PM doesn't happen if the device is in use in any way, so
there's no request flying in from upper layers. While the port is
suspended, qc's which which requested EH are short-circuited. AFAICS,
nothing is really wrong.

Thanks.

--
tejun


\
 
 \ /
  Last update: 2011-11-10 16:49    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site