Messages in this thread | | | Date | Thu, 10 Nov 2011 16:23:12 +0100 | From | Andrea Arcangeli <> | Subject | Re: [patch 2/5]thp: remove unnecessary tlb flush for mprotect |
| |
On Tue, Oct 25, 2011 at 10:59:25AM +0800, Shaohua Li wrote: > change_protection() will do TLB flush later, don't need duplicate tlb flush. > > Signed-off-by: Shaohua Li <shaohua.li@intel.com> > --- > mm/huge_memory.c | 1 - > 1 file changed, 1 deletion(-) > > Index: linux/mm/huge_memory.c > =================================================================== > --- linux.orig/mm/huge_memory.c 2011-10-24 19:24:31.000000000 +0800 > +++ linux/mm/huge_memory.c 2011-10-24 19:25:10.000000000 +0800 > @@ -1079,7 +1079,6 @@ int change_huge_pmd(struct vm_area_struc > entry = pmd_modify(entry, newprot); > set_pmd_at(mm, addr, pmd, entry); > spin_unlock(&vma->vm_mm->page_table_lock); > - flush_tlb_range(vma, addr, addr + HPAGE_PMD_SIZE); > ret = 1; > } > } else
Reviewed-by: Andrea Arcangeli <aarcange@redhat.com>
| |