lkml.org 
[lkml]   [2011]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [RFC PATCH v4 06/10] fadump: Add PT_NOTE program header for vmcoreinfo
    于 2011年11月07日 17:56, Mahesh J Salgaonkar 写道:
    > From: Mahesh Salgaonkar<mahesh@linux.vnet.ibm.com>
    >
    > Introduce a PT_NOTE program header that points to physical address of
    > vmcoreinfo_note buffer declared in kernel/kexec.c. The vmcoreinfo
    > note buffer is populated during crash_fadump() at the time of system
    > crash.
    >
    > Signed-off-by: Mahesh Salgaonkar<mahesh@linux.vnet.ibm.com>
    > ---
    > arch/powerpc/kernel/fadump.c | 29 +++++++++++++++++++++++++++++
    > 1 files changed, 29 insertions(+), 0 deletions(-)
    >
    > diff --git a/arch/powerpc/kernel/fadump.c b/arch/powerpc/kernel/fadump.c
    > index 70d6287..e68ee3a 100644
    > --- a/arch/powerpc/kernel/fadump.c
    > +++ b/arch/powerpc/kernel/fadump.c
    > @@ -816,6 +816,19 @@ static void setup_crash_memory_ranges(void)
    > }
    > }
    >
    > +/*
    > + * If the given physical address falls within the boot memory region then
    > + * return the relocated address that points to the dump region reserved
    > + * for saving initial boot memory contents.
    > + */
    > +static inline unsigned long relocate(unsigned long paddr)
    > +{
    > + if (paddr> RMR_START&& paddr< fw_dump.boot_memory_size)
    > + return fdm.rmr_region.destination_address + paddr;
    > + else
    > + return paddr;
    > +}

    Although they are static functions, it is still better to name them
    with "fadump_" prefix...

    Thanks.
    --
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2011-11-10 11:17    [W:0.022 / U:2.040 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site