lkml.org 
[lkml]   [2011]   [Nov]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] Hexagon: Use resource_size function
From
Date
Am Dienstag, den 08.11.2011, 17:02 -0800 schrieb David Brown:
> Some minor nits about the formatting of the patch.
>
> On Tue, Nov 08, 2011 at 07:49:30PM +0100, Thomas Meyer wrote:
> > From: Thomas Meyer <thomas@m3y3r.de>
>
> Shouldn't need a From: line, since it is the same as the email you
> sent it from.

So do I need a From: line or not?

Documentation/SubmittingPatches says:

The "from" line must be the very first line in the message body,
and has the form:

From: Original Author <author@example.com>

The "from" line specifies who will be credited as the author of the
patch in the permanent changelog. If the "from" line is missing,
then the "From:" line from the email header will be used to determine
the patch author in the changelog.

MUST in the meaning of RFC2119, means it is an absolut requirment. What
should I do?

OTOH some people seems to ignore this, too:

Do not send more than 15 patches at once to the vger mailing lists!!!

>
> > Use resource_size function on resource object
> > instead of explicit computation.
>
> The commit text shouldn't be indented.

Will fix that.

>
> > The semantic patch that makes this change is available
> > in scripts/coccinelle/api/resource_size.cocci.
> >
> > More information about semantic patching is available at
> > http://coccinelle.lip6.fr/
>
> I'm curious if these patches are generated directly by coccinelle,
> since they don't appear to be coming from git. It'd be nice to have
> diffstats in them (especially when they are larger).

coccinelle doesn't work that way. It's independent from git. I need to
check the manual of spatch.bin if it's possible to produce a diffstat.

> Thanks,
> David
>





\
 
 \ /
  Last update: 2011-11-10 09:41    [W:0.072 / U:0.312 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site