Messages in this thread | | | From | "Voss, Nikolaus" <> | Date | Tue, 1 Nov 2011 09:02:08 +0100 | Subject | RE: [PATCH] i2c-gpio.c: correct logic of pdata->scl_is_open_drain |
| |
> It is never correct to use push-pull I/O for i2c, so the flag does not > specify the desired behavior of the driver, it specifies what the > hardware has been configured to do so that the driver can choose the > cheapest way to do open-drain I/O.
Ok, seems rather logical after all.
> > And even if you could argue that the flag should be inverted, it has > had the same meaning since the driver was introduced several years > ago, so changing it now will break every single platform which > currently uses i2c-gpio.
I completely agree.
Thanks for the explanation, Niko
| |